Derived fields should respect causality region + Improve tests #5488
Conversation
incrypto32
force-pushed
the
krishna/fix-derived-with-fds
branch
from
78d9467 to
dbd7a64
Compare
|
|
||
| const ONCHAIN_FROM_OFFCHAIN = "CREATE_ONCHAIN_DATASOURCE_FROM_OFFCHAIN_HANDLER"; | ||
| const CREATE_FILE = "CREATE_FILE"; | ||
| // const CREATE_FILE_FROM_HANDLE_FILE = "CREATE_FILE_FROM_HANDLE_FILE"; |
There was a problem hiding this comment.
Maybe remove it, if its not used.
| @@ -90,6 +90,7 @@ impl DerivedEntityQuery { | |||
| /// Checks if a given key and entity match this query. | |||
| pub fn matches(&self, key: &EntityKey, entity: &Entity) -> bool { | |||
| key.entity_type == self.entity_type | |||
| && key.causality_region == self.causality_region | |||
There was a problem hiding this comment.
Love short implementations!
| let hash = context.getString("hash"); | ||
| log.info("Creating file data source from handleFile: {}", [hash]); | ||
| dataSource.createWithContext("File", [hash], new DataSourceContext()); | ||
| } |
There was a problem hiding this comment.
Not sure what's idiomatic for TypeScript bu wouldn't else if look more like a switch statement?
There was a problem hiding this comment.
Agree, it should have been an else if.
We cannot use switch cases though since switch-case in assemblyscript does not work with string
AssemblyScript/assemblyscript#1643
zorancv
changed the title
| entity.content = data.toString(); | ||
| entity.save(); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Can remove a nesting level by doing this block if not command and returning. Then you know all the rest are commands. as zoran said it's prolly more of a switch case, mostly for making it a bit easier to maintain and read if you think it's worth. But also none of the ifs return when match so that could create some weird test situations 😆
There was a problem hiding this comment.
Agreed, making the change.
incrypto32
force-pushed
the
krishna/fix-derived-with-fds
branch
from
96a3d38 to
c0b4cb0
Compare
Closes #5267